acceptance: skip pydabs_1000_tasks in migrate + continue_293 invariants#5062
Merged
Conversation
denik
reviewed
Apr 22, 2026
The 1000-task scale case is still exercised by `no_drift`; running the same scale in `migrate` and `continue_293` adds dominant time in PR CI without incremental coverage. Measured against a recent main build: linux/direct migrate=228s continue_293=98s (no_drift kept=94s) windows/direct migrate=422s continue_293=143s (no_drift kept=109s) These two excluded tests are the top-2 slowest tests on linux/direct and the top-2 on windows/direct, so this is the high-leverage cut. Co-authored-by: Isaac
pietern
changed the title
denik
approved these changes
May 7, 2026
denik
pushed a commit
that referenced
this pull request
May 20, 2026
…ts (#5062) Drop `job_pydabs_1000_tasks` from the `migrate` and `continue_293` invariants — they are the top-2 slowest acceptance tests on `*/direct` jobs. `no_drift` still runs the same 1000-task config every PR, so the deploy + plan path stays covered at scale. We do lose some coverage: scale-specific bugs in the terraform→direct state migration path (`migrate`) or in v0.293.0-state back-compat (`continue_293`) wouldn't be caught at 1000 tasks anymore. Both invariants still run their full set of other configs every PR. Given how heavy these two tests are, the trade-off is worth it. The real fix is to make the 1000-task case fast in principle, but that's a separate effort. This PR buys back PR-CI time today; speeding up the underlying path is what makes the dropped coverage cheap to restore later. Measured savings vs main: - linux/direct: 8m47s → 5m20s - macos/direct: 11m9s → 8m19s - windows/direct: 25m44s → 24m15s This pull request and its description were written by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
job_pydabs_1000_tasksfrom themigrateandcontinue_293invariants — they are the top-2 slowest acceptance tests on*/directjobs.no_driftstill runs the same 1000-task config every PR, so the deploy + plan path stays covered at scale.We do lose some coverage: scale-specific bugs in the terraform→direct state migration path (
migrate) or in v0.293.0-state back-compat (continue_293) wouldn't be caught at 1000 tasks anymore. Both invariants still run their full set of other configs every PR. Given how heavy these two tests are, the trade-off is worth it.The real fix is to make the 1000-task case fast in principle, but that's a separate effort. This PR buys back PR-CI time today; speeding up the underlying path is what makes the dropped coverage cheap to restore later.
Measured savings vs main:
This pull request and its description were written by Isaac.